-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix heap cost calculation rounding error #30673
fix heap cost calculation rounding error #30673
Conversation
@Lichtso if this is a valid change, it probably needs a feature gate, or perhaps can be rolled into other feature gates if possible? |
Yes, it needs a feature gate, and I can't think of any other related one to merge this change into. |
443dbf3
to
ce86db9
Compare
Thanks for quick response. Feature gate added. |
Codecov Report
@@ Coverage Diff @@
## master #30673 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 723 723
Lines 201672 201646 -26
=========================================
- Hits 164766 164744 -22
+ Misses 36906 36902 -4 |
70be670
to
1aa3fe8
Compare
* add test for refaction heap size, fix size truncating by div op * add feature gate * checked result of consume_checked() if feature is activated
* add test for refaction heap size, fix size truncating by div op * add feature gate * checked result of consume_checked() if feature is activated
Problem
Should round up heap size to next 32k block before
div
Summary of Changes
consume_checked
if feature is activatedOPTIONAL: Feature Gate Issue: #30679