Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Gate: round up heap size when calculating heap cost #30679

Closed
tao-stones opened this issue Mar 10, 2023 · 0 comments
Closed

Feature Gate: round up heap size when calculating heap cost #30679

tao-stones opened this issue Mar 10, 2023 · 0 comments
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@tao-stones
Copy link
Contributor

tao-stones commented Mar 10, 2023 •
edited
Loading

Description

when calculating number of units additional heap cost, heap size should be round up first. This change alters how loader consume units in some cases, therefore needs to be feature gated.

Feature ID

CE2et8pqgyQMP2mQRg3CgvX8nJBKUArMu3wfiQiQKY1y

Activation Method

Single Core Contributor

Minimum Beta Version

1.16.0

Minimum Stable Version

No response

Testnet Activation Epoch

504

Devnet Activation Epoch

568

Mainnet-Beta Activation Epoch

545
@tao-stones tao-stones added the feature-gate Pull Request adds or modifies a runtime feature gate label Mar 10, 2023
@tao-stones tao-stones changed the title Feature Gate: round up heap size Feature Gate: round up heap size when calculating heap cost Mar 10, 2023
@tao-stones tao-stones mentioned this issue Mar 10, 2023
Merged
@tao-stones tao-stones mentioned this issue Dec 11, 2023
Merged
@Lichtso Lichtso closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lichtso @tao-stones