RPC: Improve unsupported transaction error message #28249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
(cherry picked from commit db37d6b)
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
(cherry picked from commit db37d6b)
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
(cherry picked from commit db37d6b)
mergify bot
added a commit
that referenced
this pull request
Oct 6, 2022
…28253) RPC: Improve unsupported transaction error message (#28249) (cherry picked from commit db37d6b) Co-authored-by: Justin Starry <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Oct 6, 2022
…28252) RPC: Improve unsupported transaction error message (#28249) (cherry picked from commit db37d6b) Co-authored-by: Justin Starry <[email protected]>
65 tasks
mergify bot
added a commit
that referenced
this pull request
Oct 6, 2022
…28254) RPC: Improve unsupported transaction error message (#28249) (cherry picked from commit db37d6b) Co-authored-by: Justin Starry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Transaction version ({0}) is not supportederror message is not very clear or actionable. It appears to be an error that the RPC API server needs to fix rather than the client.Summary of Changes
Make it clear that the requestor needs to pass a param if they request an unsupported transaction version and receive an error
Fixes #