RPC: Improve unsupported transaction error message (#28249)

(cherry picked from commit db37d6b)
solana-labs · Oct 6, 2022 · bbae69c · bbae69c
1 parent f43352b
commit bbae69c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/client/src/rpc_custom_error.rs b/client/src/rpc_custom_error.rs
@@ -194,7 +194,12 @@ impl From<RpcCustomError> for Error {
             },
             RpcCustomError::UnsupportedTransactionVersion(version) => Self {
                 code: ErrorCode::ServerError(JSON_RPC_SERVER_ERROR_UNSUPPORTED_TRANSACTION_VERSION),
-                message: format!("Transaction version ({}) is not supported", version),
+                message: format!(
+                    "Transaction version ({0}) is not supported by the requesting client. \
+                    Please try the request again with the following configuration parameter: \
+                    \"maxSupportedTransactionVersion\": {0}",
+                    version
+                ),
                 data: None,
             },
             RpcCustomError::MinContextSlotNotReached { context_slot } => Self {

diff --git a/rpc/src/rpc.rs b/rpc/src/rpc.rs
@@ -6634,7 +6634,11 @@ pub mod tests {
         let response = parse_failure_response(rpc.handle_request_sync(request));
         let expected = (
             JSON_RPC_SERVER_ERROR_UNSUPPORTED_TRANSACTION_VERSION,
-            String::from("Transaction version (0) is not supported"),
+            String::from(
+                "Transaction version (0) is not supported by the requesting client. \
+                Please try the request again with the following configuration parameter: \
+                \"maxSupportedTransactionVersion\": 0",
+            ),
         );
         assert_eq!(response, expected);
     }