This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Consensus Logging #28176
Merged
Consensus Logging #28176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
reviewed
Oct 3, 2022
| @@ -778,6 +778,25 @@ pub(crate) fn check_slot_agrees_with_cluster( | |||
| return; | |||
| } | |||
| } | |||
|
|
|||
| datapoint_info!( | |||
| "duplicate_confirmed", | |||
There was a problem hiding this comment.
Lets add one for Duplicate as well
| @@ -2968,9 +2973,14 @@ impl ReplayStage { | |||
| // then there will be no blocks to include the votes for slot 4, and the network halts | |||
| // because 90% of validators can't vote | |||
| info!( | |||
| "Waiting to switch vote to {}, resetting to slot {:?} for now", | |||
| "Waiting to switch vote to {}, | |||
| resetting to slot {:?} for now, | |||
There was a problem hiding this comment.
nit: might as well add threshold: total_stake * .38 to make the log complete
AshwinSekar
approved these changes
Oct 3, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
(cherry picked from commit 14a415c)
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
(cherry picked from commit 14a415c)
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
(cherry picked from commit 14a415c)
carllin
added a commit
that referenced
this pull request
Oct 4, 2022
(cherry picked from commit 14a415c)
carllin
added a commit
that referenced
this pull request
Oct 4, 2022
(cherry picked from commit 14a415c)
carllin
added a commit
that referenced
this pull request
Oct 4, 2022
(cherry picked from commit 14a415c)
mergify bot
added a commit
that referenced
this pull request
Oct 4, 2022
Consensus Logging (#28176) (cherry picked from commit 14a415c) Co-authored-by: carllin <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Oct 4, 2022
Consensus Logging (#28176) (cherry picked from commit 14a415c) Co-authored-by: carllin <[email protected]>
|
@Mergifyio backport v1.13 |
✅ Backports have been created
|
willhickey
added a commit
that referenced
this pull request
Oct 11, 2022
* Consensus Logging (#28176) * dereference bank_slot Co-authored-by: carllin <[email protected]>
carllin
added a commit
to carllin/solana
that referenced
this pull request
Oct 17, 2022
carllin
added a commit
to carllin/solana
that referenced
this pull request
Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need more insight into DuplicateConfirmed/bank frozen versions
Summary of Changes
Fixes #