Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Missing metrics for dupe slots #28210

Closed
joeaba opened this issue Oct 4, 2022 · 3 comments
Closed

Missing metrics for dupe slots #28210

joeaba opened this issue Oct 4, 2022 · 3 comments
Assignees
@yihau
Labels
validator Issues that relate to the validator

Comments

@joeaba
Copy link
Contributor

joeaba commented Oct 4, 2022

Problem

We don't have a way to easily monitor for dupe slots

Proposed Solution

Add a metric here:
https://github.com/solana-labs/solana/blob/adc4e633a/core/src/window_service.rs#L142-L153
or here:
https://github.com/solana-labs/solana/blob/adc4e633a/core/src/replay_stage.rs#L1462
@joeaba
Copy link
Contributor Author

joeaba commented Oct 4, 2022

@yihau @pieceofr have you guys added metrics yet?

@sakridge sakridge added the validator Issues that relate to the validator label Oct 21, 2022
@yihau yihau self-assigned this Oct 28, 2022
@yihau
Copy link
Contributor

yihau commented Oct 28, 2022

just found this. is it the same thing? #28176

@joeaba
Copy link
Contributor Author

joeaba commented Oct 28, 2022

lol yes, closing this

@joeaba joeaba closed this as completed Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yihau yihau

Labels
validator Issues that relate to the validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sakridge @yihau @joeaba