Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove markdown file update from version increment-cargo-version.sh #27851

Merged
merged 3 commits into from
Sep 19, 2022
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/src/developing/clients/jsonrpc-api.md
Original file line number Diff line number Diff line change
@@ -215,7 +215,7 @@ JSON parsing for the following native and SPL programs:

| Program | Account State | Instructions |
| --- | --- | --- |
| Address Lookup | v1.15.0 | v1.15.0 |
willhickey marked this conversation as resolved.
Show resolved Hide resolved
| Address Lookup | v1.12.0 | v1.12.0 |
| BPF Loader | n/a | stable |
| BPF Upgradeable Loader | stable | stable |
| Config | stable | |
@@ -1949,7 +1949,7 @@ Returns all accounts owned by the provided program Pubkey
- `offset: <usize>` - offset into program account data to start comparison
- `bytes: <string>` - data to match, as encoded string
- `encoding: <string>` - encoding for filter `bytes` data, either "base58" or "base64". Data is limited in size to 128 or fewer decoded bytes.
**NEW: This field, and base64 support generally, is only available in solana-core v1.15.0 or newer. Please omit when querying nodes on earlier versions**
**NEW: This field, and base64 support generally, is only available in solana-core v1.11.2 or newer. Please omit when querying nodes on earlier versions**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!


- `dataSize: <u64>` - compares the program account data length with the provided data size

11 changes: 0 additions & 11 deletions scripts/increment-cargo-version.sh
Original file line number Diff line number Diff line change
@@ -33,8 +33,6 @@ done

# shellcheck disable=2207
Cargo_tomls=($(find . -mindepth 2 -name Cargo.toml "${not_paths[@]}"))
# shellcheck disable=2207
markdownFiles=($(find . -name "*.md" "${not_paths[@]}"))

# Collect the name of all the internal crates
crates=()
@@ -138,15 +136,6 @@ for Cargo_toml in "${Cargo_tomls[@]}"; do
done
done

# Update all the documentation references
for file in "${markdownFiles[@]}"; do
# Set new crate version
(
set -x
sed -i "$file" -e "s/$currentVersion/$newVersion/g"
)
done

CriesofCarrots marked this conversation as resolved.
Show resolved Hide resolved
# Update cargo lock files
scripts/cargo-for-all-lock-files.sh tree >/dev/null