Remove markdown file update from version increment-cargo-version.sh #27851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1949,7 +1949,7 @@ Returns all accounts owned by the provided program Pubkey | |||
| - `offset: <usize>` - offset into program account data to start comparison | |||
| - `bytes: <string>` - data to match, as encoded string | |||
| - `encoding: <string>` - encoding for filter `bytes` data, either "base58" or "base64". Data is limited in size to 128 or fewer decoded bytes. | |||
| **NEW: This field, and base64 support generally, is only available in solana-core v1.15.0 or newer. Please omit when querying nodes on earlier versions** | |||
| **NEW: This field, and base64 support generally, is only available in solana-core v1.11.2 or newer. Please omit when querying nodes on earlier versions** | |||
CriesofCarrots
previously approved these changes
Sep 17, 2022
There was a problem hiding this comment.
r+ reverting the Address Lookup change.
(Also, just for historical documentation purposes, I fixed the Address Lookup versions in v1.14/published docs here: #27806)
mergify
bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
…27851) * Remove markdown file update from version increment-cargo-version.sh * Update doc version numbers that were incorrectly advanced by increment-cargo-version.sh * Revert incorrect doc change based on review feedback (cherry picked from commit 8f96a39) # Conflicts: # docs/src/developing/clients/jsonrpc-api.md
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
…27851) * Remove markdown file update from version increment-cargo-version.sh * Update doc version numbers that were incorrectly advanced by increment-cargo-version.sh * Revert incorrect doc change based on review feedback (cherry picked from commit 8f96a39) # Conflicts: # docs/src/developing/clients/jsonrpc-api.md
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
…27851) * Remove markdown file update from version increment-cargo-version.sh * Update doc version numbers that were incorrectly advanced by increment-cargo-version.sh * Revert incorrect doc change based on review feedback (cherry picked from commit 8f96a39) # Conflicts: # docs/src/developing/clients/jsonrpc-api.md
mergify bot
added a commit
that referenced
this pull request
Sep 26, 2022
…backport #27851) (#27928) * Remove markdown file update from version increment-cargo-version.sh (#27851) * Remove markdown file update from version increment-cargo-version.sh * Update doc version numbers that were incorrectly advanced by increment-cargo-version.sh * Revert incorrect doc change based on review feedback (cherry picked from commit 8f96a39) # Conflicts: # docs/src/developing/clients/jsonrpc-api.md * Resolve conflict Co-authored-by: Will Hickey <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Oct 4, 2022
…backport #27851) (#27926) * Remove markdown file update from version increment-cargo-version.sh (#27851) * Remove markdown file update from version increment-cargo-version.sh * Update doc version numbers that were incorrectly advanced by increment-cargo-version.sh * Revert incorrect doc change based on review feedback (cherry picked from commit 8f96a39) # Conflicts: # docs/src/developing/clients/jsonrpc-api.md * Resolve merge conflict Co-authored-by: Will Hickey <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Oct 4, 2022
…backport #27851) (#27927) * Remove markdown file update from version increment-cargo-version.sh (#27851) * Remove markdown file update from version increment-cargo-version.sh * Update doc version numbers that were incorrectly advanced by increment-cargo-version.sh * Revert incorrect doc change based on review feedback (cherry picked from commit 8f96a39) # Conflicts: # docs/src/developing/clients/jsonrpc-api.md * Resolve merge conflict Co-authored-by: Will Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
increment-cargo-version.sh increments version numbers in markdown files. This behavior is no longer necessary and sometimes increments version numbers that should be static.
Some discussion here:
https://discord.com/channels/428295358100013066/560503042458517505/1020445231004532810
Summary of Changes