Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect and re-forward packets received while TpuForwarder is shutting down #2766

Merged
merged 3 commits into from
Feb 15, 2019

Conversation

mvines
Copy link
Member

@mvines mvines commented Feb 15, 2019

This is a follow-up to #2758 which unlocks the test_two_fullnodes_rotate_every_tick_with_transactions multinode test.

When a node is transitioning from validator to leader, the TpuForwarder may have inflight packets that should be retained (just like the BankingStage did when transitioning from leader to validator). The fix is the same, collect all the inflight packets and pass them along once the transition is complete.

This PR contains a slight refactoring of how fullnode manages transitions to:

  • Remove duplication between Fullnode::new() and Fullnode::rotate()
  • Consolidate the calls to cluster_info::set_leader() that were occurring randomly about the tree into the Tpu, so that it aligns exactly with the state of the transition

Fixes #2675 even more than before.

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #2766 into master will increase coverage by <.1%.
The diff coverage is 70.7%.

@@           Coverage Diff            @@
##           master   #2766     +/-   ##
========================================
+ Coverage    78.7%   78.7%   +<.1%     
========================================
  Files         115     115             
  Lines       19437   19422     -15     
========================================
- Hits        15301   15296      -5     
+ Misses       4136    4126     -10

@mvines mvines merged commit 71ab030 into solana-labs:master Feb 15, 2019
@mvines mvines deleted the ocho branch February 15, 2019 02:40
yihau pushed a commit to yihau/solana that referenced this pull request Sep 28, 2024
…olana-labs#2766)

Remove explicit stream finish (solana-labs#2760)

(cherry picked from commit 61d6a22)

Co-authored-by: Lijun Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore DEFAULT_TICKS_PER_SLOT to 8 for a ~800ms voting interval
1 participant