Add TPU forwarding of unprocessed but received packets, and restore 8 ticks per slot #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
added
work in progress
mvines
force-pushed
the
ocho
branch
4 times, most recently
from
4a6ffa2 to
47af707
Compare
Codecov Report
@@ Coverage Diff @@
## master #2758 +/- ##
========================================
+ Coverage 78.8% 78.8% +<.1%
========================================
Files 115 115
Lines 19372 19407 +35
========================================
+ Hits 15268 15299 +31
- Misses 4104 4108 +4 |
mvines
force-pushed
the
ocho
branch
2 times, most recently
from
d992ce2 to
7553bda
Compare
This reverts commit 2d2572d.
garious
approved these changes
Feb 14, 2019
sagar-solana
approved these changes
Feb 14, 2019
joncinque
pushed a commit
to joncinque/solana
that referenced
this pull request
Aug 28, 2024
…abs#2758) * Return error if epoch_boundary_block is not actually the epoch boundary block * Update rpc-client-api/src/custom_error.rs Co-authored-by: Trent Nelson <[email protected]> --------- Co-authored-by: Trent Nelson <[email protected]>
willhickey
pushed a commit
that referenced
this pull request
Aug 31, 2024
…ackport of #2758) (#2781) * RPC: rewards, return error if epoch_boundary_block is a lie (#2758) * Return error if epoch_boundary_block is not actually the epoch boundary block * Update rpc-client-api/src/custom_error.rs Co-authored-by: Trent Nelson <[email protected]> --------- Co-authored-by: Trent Nelson <[email protected]> (cherry picked from commit 9a4b094) # Conflicts: # rpc-client-api/src/custom_error.rs # rpc/src/rpc.rs * Fix conflicts --------- Co-authored-by: Tyera <[email protected]>
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Sep 28, 2024
…ckport of solana-labs#2758) (solana-labs#2767) RPC: rewards, return error if epoch_boundary_block is a lie (solana-labs#2758) * Return error if epoch_boundary_block is not actually the epoch boundary block * Update rpc-client-api/src/custom_error.rs Co-authored-by: Trent Nelson <[email protected]> --------- Co-authored-by: Trent Nelson <[email protected]> (cherry picked from commit 9a4b094) Co-authored-by: Tyera <[email protected]>
behzadnouri
pushed a commit
to behzadnouri/solana
that referenced
this pull request
Oct 10, 2024
…ackport of solana-labs#2758) (solana-labs#2781) * RPC: rewards, return error if epoch_boundary_block is a lie (solana-labs#2758) * Return error if epoch_boundary_block is not actually the epoch boundary block * Update rpc-client-api/src/custom_error.rs Co-authored-by: Trent Nelson <[email protected]> --------- Co-authored-by: Trent Nelson <[email protected]> (cherry picked from commit 9a4b094) # Conflicts: # rpc-client-api/src/custom_error.rs # rpc/src/rpc.rs * Fix conflicts --------- Co-authored-by: Tyera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a quick slot leader rotation (~8 ticks per slot), clients that talk directly to a leader node are likely to experience a high rate to dropped transactions during the time that PoH max height is reached and the TPU switches into forwarding mode. This is even worse for testnets with leader rotation disabled, where every ~800ms the leader accepts transactions but immediately drops them as it's going through its rotation gymnastics. This wreaks havoc on integration tests and the SDK development environment.
Instead we can easily collect all transaction packets received by the fetch stage that have yet to make it into the bank, and forward them to the next leader (which may in fact be the same node).
TODO:
ci/localnet-sanity.shseem to be happy with this PR, but there are a bunch of upset unit tests (banking_stage.rs in particular)Fixes #2675