This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Fix resource hogging when waiting for role transition #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2676 +/- ##
========================================
- Coverage 76.6% 76.6% -0.1%
========================================
Files 114 114
Lines 18583 18588 +5
========================================
+ Hits 14249 14250 +1
- Misses 4334 4338 +4 |
sagar-solana
commented
Feb 7, 2019
src/fullnode.rs
Outdated
| @@ -103,6 +103,7 @@ pub struct Fullnode { | |||
| broadcast_socket: UdpSocket, | |||
| pub node_services: NodeServices, | |||
| pub role_notifiers: (TvuRotationReceiver, TpuRotationReceiver), | |||
| role_senders: (TvuRotationSender, TpuRotationSender), | |||
There was a problem hiding this comment.
@mvines, haalp. This turned out a bit ugly. I need to cache the senders so that I can reliably abort when exit is signaled on the closure returned form run().
mvines
approved these changes
Feb 7, 2019
joncinque
pushed a commit
to joncinque/solana
that referenced
this pull request
Aug 22, 2024
…checking it in ProgressMap. (solana-labs#2676) * Check poh_recorder.start_slot() hasn't been dumped previously before checking it in progress_map. * Add more comments and put in checks for maybe_start_leader. * Update core/src/replay_stage.rs Co-authored-by: Ashwin Sekar <[email protected]> * Use a slot which I am not leader to avoid dumping my own slot panic. * Address reviewer comments. * Address reviewer comments. --------- Co-authored-by: Ashwin Sekar <[email protected]>
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Aug 27, 2024
…efore checking it in ProgressMap. (backport of solana-labs#2676) (solana-labs#2691) Check poh_recorder.start_slot() hasn't been dumped previously before checking it in ProgressMap. (solana-labs#2676) * Check poh_recorder.start_slot() hasn't been dumped previously before checking it in progress_map. * Add more comments and put in checks for maybe_start_leader. * Update core/src/replay_stage.rs Co-authored-by: Ashwin Sekar <[email protected]> * Use a slot which I am not leader to avoid dumping my own slot panic. * Address reviewer comments. * Address reviewer comments. --------- Co-authored-by: Ashwin Sekar <[email protected]> (cherry picked from commit 053faa6) Co-authored-by: Wen <[email protected]>
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Aug 27, 2024
…checking it in ProgressMap. (solana-labs#2676) * Check poh_recorder.start_slot() hasn't been dumped previously before checking it in progress_map. * Add more comments and put in checks for maybe_start_leader. * Update core/src/replay_stage.rs Co-authored-by: Ashwin Sekar <[email protected]> * Use a slot which I am not leader to avoid dumping my own slot panic. * Address reviewer comments. * Address reviewer comments. --------- Co-authored-by: Ashwin Sekar <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The loop in
handle_role_transitionis non-blocking so it just sits there spinning until it receives a rotation signal from a TPU/TVUMore info: #2645
Summary of Changes
Switched to revc_timeout from revc and wait for the correct TPU/TVU receiver to signal a transition.
Fixes #2645