Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

process_ledger() takes an Entry iterator, should take a ledger #2691

Closed
rob-solana opened this issue Feb 7, 2019 · 0 comments
Closed

process_ledger() takes an Entry iterator, should take a ledger #2691

rob-solana opened this issue Feb 7, 2019 · 0 comments

Comments

@rob-solana
Copy link
Contributor

Problem

an Entry iterator is the wrong thing to replay a ledger for node startup, because it has no forks

Proposed Solution

have process_ledger take db_ledger instead of an iterator

complications:
ledger_tool
@garious garious added this to the The Future! milestone Feb 13, 2019
@garious garious removed this from the The Future! milestone Apr 27, 2019
CriesofCarrots pushed a commit to CriesofCarrots/solana that referenced this issue Aug 27, 2024
@mergify @wen-coding
v2.0: Check poh_recorder.start_slot() hasn't been dumped previously b…
a210e0c 
…efore checking it in ProgressMap. (backport of solana-labs#2676) (solana-labs#2691)

Check poh_recorder.start_slot() hasn't been dumped previously before checking it in ProgressMap. (solana-labs#2676)

* Check poh_recorder.start_slot() hasn't been dumped previously before checking it in progress_map.

* Add more comments and put in checks for maybe_start_leader.

* Update core/src/replay_stage.rs

Co-authored-by: Ashwin Sekar <[email protected]>

* Use a slot which I am not leader to avoid dumping my own slot panic.

* Address reviewer comments.

* Address reviewer comments.

---------

Co-authored-by: Ashwin Sekar <[email protected]>
(cherry picked from commit 053faa6)

Co-authored-by: Wen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garious @rob-solana