[abandoned] Do not check accounts data size in InvokeContext #26627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
added
feature-gate
brooksprumo
force-pushed
the
accounts-data-len/invoke-context
branch
from
e873872
to
b43ac4f
Compare
brooksprumo
added
work in progress
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
stale
brooksprumo
force-pushed
the
accounts-data-len/invoke-context
branch
from
b43ac4f
to
dfadbbd
Compare
brooksprumo
added
CI
|
Closing, as this PR has been subsumed by #26773 |
brooksprumo
removed
the
feature-gate
brooksprumo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Original issue: #26439
Checking if the bank has exceeded the accounts data size limits cannot be done during instruction processing; it must be reserved until the end of the bank where there is no parallel execution, and thus will be handled deterministically across the cluster.
Summary of Changes
Do not throw errors inside of InvokeContext if the AccountsDataMeter exceeds the maximum. Note, the
cap_accounts_data_lenfeature is not activated, so there are zero runtime changes to currently-running clusters.Future PRs will move/add these checks to ReplayStage when the bank has completed.
Feature Gate Issue: modifies #24135