Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RpcResponseContext in rpc_client test #25296

Merged
merged 1 commit into from
May 17, 2022
Merged

Fix RpcResponseContext in rpc_client test #25296

merged 1 commit into from
May 17, 2022

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented May 17, 2022 •
edited
Loading

Problem

I broke the build:

error[E0063]: missing field `api_version` in initializer of `rpc_response::RpcResponseContext`
    --> client/src/rpc_client.rs:4338:34
     |
4338 |                         context: RpcResponseContext { slot: 1 },
     |                                  ^^^^^^^^^^^^^^^^^^ missing `api_version`

https://buildkite.com/solana-labs/solana/builds/73654#85d3587f-4854-49f1-b3a7-b332bc50680e
PR the introduced the break: #25200

Summary of Changes

Add api_version.

@brooksprumo brooksprumo marked this pull request as ready for review May 17, 2022 17:25
@brooksprumo
Copy link
Contributor Author

CI 'checks' has passed; merging.

@brooksprumo brooksprumo merged commit dff089e into solana-labs:master May 17, 2022
@brooksprumo brooksprumo deleted the fix-rpc_client branch May 17, 2022 17:44
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
@brooksprumo @jeffwashington
Fix RpcResponseContext in rpc_client test (solana-labs#25296)
231efcc
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
@brooksprumo @jeffwashington
Fix RpcResponseContext in rpc_client test (solana-labs#25296)
8645d6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brooksprumo