Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_stake_minimum_delegation() to rpc_client #25200

Conversation

brooksprumo
Copy link
Contributor

Problem

There is not a way for rpc client to get the stake minimum delegation.

Summary of Changes

Add get_stake_minimum_delegation() to rpc_client.

Fixes #24690

@brooksprumo brooksprumo force-pushed the minimum-stake/rpc_client/get_stake_minimum_delegation branch from 0f0f473 to 990d7e0 Compare May 13, 2022 18:51
@brooksprumo brooksprumo marked this pull request as ready for review May 14, 2022 20:00
@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #25200 (990d7e0) into master (69a0ff9) will increase coverage by 0.0%.
The diff coverage is 81.5%.

❗ Current head 990d7e0 differs from pull request most recent head e8252e9. Consider uploading reports for the commit e8252e9 to get more accurate results

@@            Coverage Diff            @@
##           master   #25200     +/-   ##
=========================================
  Coverage    82.0%    82.1%             
=========================================
  Files         598      602      +4     
  Lines      165882   166888   +1006     
=========================================
+ Hits       136125   137062    +937     
- Misses      29757    29826     +69     

CriesofCarrots
CriesofCarrots previously approved these changes May 17, 2022
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just nits

client/src/nonblocking/rpc_client.rs Outdated Show resolved Hide resolved
client/src/nonblocking/rpc_client.rs Outdated Show resolved Hide resolved
@mergify mergify bot dismissed CriesofCarrots’s stale review May 17, 2022 14:25

Pull request has been modified.

@brooksprumo brooksprumo merged commit e608580 into solana-labs:master May 17, 2022
@brooksprumo brooksprumo deleted the minimum-stake/rpc_client/get_stake_minimum_delegation branch May 17, 2022 16:46
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to get stake minimum delegation from RPC
2 participants