Don't extract invoked keys from a message when using a lookup table #25065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
lut/prohibit-dynamic-program-ids
branch
from
bf8ffff to
361f461
Compare
jstarry
force-pushed
the
lut/prohibit-dynamic-program-ids
branch
from
361f461 to
7f3680b
Compare
Codecov Report
@@ Coverage Diff @@
## master #25065 +/- ##
========================================
Coverage 82.0% 82.0%
========================================
Files 598 598
Lines 165882 166224 +342
========================================
+ Hits 136125 136463 +338
- Misses 29757 29761 +4 |
joncinque
approved these changes
May 12, 2022
Comment on lines
+189
to
+195
| bitflags! { | ||
| pub struct KeyFlags: u8 { | ||
| const SIGNER = 0b00000001; | ||
| const WRITABLE = 0b00000010; | ||
| const INVOKED = 0b00000100; | ||
| } | ||
| } |
There was a problem hiding this comment.
Very slick, too bad it's only for testing!
There was a problem hiding this comment.
Haha, I did try to incorporate it into the compilation code but booleans proved to be easier to work with. Happy I was able to work them in somehow though :)
jstarry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Once the feature for #25034 is activated, program ids will no longer be allowed to be loaded from a lookup table. However, the client message building api still extracts program ids using lookup tables.
Summary of Changes
CompiledKeysto allow for filtering out invoked keysFixes #