Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Gate: Require static program ids in transactions #25034

Closed
jstarry opened this issue May 6, 2022 · 3 comments
Closed

Feature Gate: Require static program ids in transactions #25034

jstarry opened this issue May 6, 2022 · 3 comments
Assignees
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@jstarry
Copy link
Member

jstarry commented May 6, 2022

Description

Transaction ingestion cannot do static analysis over transaction program instructions to determine user fees, precompile usage, and estimated compute without first loading addresses from on-chain lookup tables. This feature gate adds a sanitization requirement that top-level program ids for transaction instructions are in the raw transaction and not loaded from a lookup table.

Feature ID

8FdwgyHFEjhAdjWfV2vfqk7wA1g9X3fQpKH7SBpEv3kC

Release

v1.10.13

Activation Method

Single Core Contributor

Testnet Activation Epoch

348

Devnet Activation Epoch

358

Mainnet-Beta Activation Epoch

355

@ptaffet-jump
Copy link

Unless I'm misunderstanding something, this is active in Mainnet (transaction UKCkK8Nm5b1TmhM98Ji3x6mmpfmy7mPBvqUV3JwxVQDMHi6fYeQ2RhzjoGahPBCYtmnqXhT1rgRfCWYEb1sFeGU). Would you mind updating the status and/or closing the issue?

@CriesofCarrots
Copy link
Contributor

Would you mind updating the status and/or closing the issue?

I added the mnb activation epoch. We typically close these issues when the feature-gating logic has been cleaned up in master.

@ptaffet-jump
Copy link

Makes sense. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

No branches or pull requests

3 participants