Revert: KeyedAccount refactoings in builtin programs
#23649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
revert/keyed_account_refactoings_in_builtin_programs
branch
4 times, most recently
from
ce83ddf to
9cd9fd9
Compare
Lichtso
force-pushed
the
revert/keyed_account_refactoings_in_builtin_programs
branch
from
9cd9fd9 to
a69207c
Compare
Codecov Report
@@ Coverage Diff @@
## master #23649 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 580 580
Lines 158184 158151 -33
=========================================
- Hits 129341 129271 -70
- Misses 28843 28880 +37 |
|
Compared this to v1.9, lgtm |
Lichtso
deleted the
revert/keyed_account_refactoings_in_builtin_programs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@jackcmay and me came to the conclusion that the recent refactoings in builtin programs are too hard to review.
So we decided to revert them so that we can reapply them in a structured and clean way.
Summary of Changes
Reverts #23375, #23348, #23302, #23214, #23217, #23056.
Some conflicts occurred and had to be resolved because of changes in the meantime (such as checked integer arithmetic and checked array accesses which were added).
Fixes #