-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Prepare stake_instruction.rs to remove KeyedAccount
s
#23375
Merged
Lichtso
merged 4 commits into
solana-labs:master
from
Lichtso:refactor/remove_keyed_accounts_11
Feb 28, 2022
Merged
Refactor: Prepare stake_instruction.rs to remove KeyedAccount
s
#23375
Lichtso
merged 4 commits into
solana-labs:master
from
Lichtso:refactor/remove_keyed_accounts_11
Feb 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Mar 4, 2022
…ana-labs#23375) * Adds instruction_account_indices to stake instruction. * Uses instruction_account_indices in stake instruction. * Replaces get_sysvar_with_account_check by get_sysvar_with_account_check2 in stake instruction. * Adds check_number_of_instruction_accounts().
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Mar 14, 2022
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Mar 14, 2022
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Mar 14, 2022
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Mar 14, 2022
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Mar 15, 2022
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Mar 15, 2022
Lichtso
added a commit
that referenced
this pull request
Mar 16, 2022
* Revert "Replaces KeyedAccount by BorrowedAccount in the BPF loader. (#23056)" 6c56eb9 * Revert "Replaces `KeyedAccount` by `BorrowedAccount` in `system_instruction_processor`. (#23217)" ee7e411 * Revert "Replaces `KeyedAccount` by `BorrowedAccount` in `nonce_keyed_account`. (#23214)" 1a68f81 * Revert "Replaces KeyedAccount by BorrowedAccount in the config processor. (#23302)" a14c7c3 * Revert "Replaces `KeyedAccount` by `BorrowedAccount` in vote processor (#23348)" e2fa6a0 * Revert "Refactor: Prepare stake_instruction.rs to remove `KeyedAccount`s (#23375)" ee3fc39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
stake_instruction.rs is not using
instruction_account_indices
yet.Summary of Changes
instruction_account_indices
get_sysvar_with_account_check()
byget_sysvar_with_account_check2()
check_number_of_instruction_accounts()
Fixes #