This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
plumbing for 'other_slot' in 'update_index' #23330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
feb2_with_trait_tests
branch
from
8013a7b to
aafe4d0
Compare
jeffwashington
force-pushed
the
feb2_with_trait_tests
branch
from
aafe4d0 to
d9aecdd
Compare
brooksprumo
approved these changes
Feb 25, 2022
Comment on lines
1748
to
+1751
| pub fn upsert( | ||
| &self, | ||
| slot: Slot, | ||
| new_slot: Slot, | ||
| _old_slot: Slot, |
There was a problem hiding this comment.
Can you add doc comments on what old_slot is? This can be on the next PR too, just wanted to call it out.
Codecov Report
@@ Coverage Diff @@
## master #23330 +/- ##
=======================================
Coverage 81.3% 81.3%
=======================================
Files 572 572
Lines 155914 155929 +15
=======================================
+ Hits 126882 126910 +28
+ Misses 29032 29019 -13 |
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Mar 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
prep for #23311
this is used by ancient append vecs. Broken out here because of all the files and tests it touches.
Summary of Changes
Fixes #