This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
allow index update to change storage slot # #23311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
feb2_with_trait
branch
from
180794b to
d0f99c5
Compare
jeffwashington
changed the title
jeffwashington
force-pushed
the
feb2_with_trait
branch
from
d0f99c5 to
f24fa07
Compare
jeffwashington
force-pushed
the
feb2_with_trait
branch
8 times, most recently
from
94636a6 to
4bda786
Compare
jeffwashington
force-pushed
the
feb2_with_trait
branch
from
4bda786 to
32dff59
Compare
brooksprumo
reviewed
Feb 28, 2022
There was a problem hiding this comment.
I think this looks good. It's hard for me to think about all the cases here, esp with add/deref. So like the comments below, maybe more tests/debug asserts would be valuable (if possible)?
Or maybe there's a way to refactor/simplify the loop in update_slot_list()? It feels like there's some code duplication (but maybe not enough?).
Probably just getting lots of runtime on this is good.
jeffwashington
force-pushed
the
feb2_with_trait
branch
4 times, most recently
from
867f4c7 to
cb06e8c
Compare
brooksprumo
reviewed
Feb 28, 2022
jeffwashington
force-pushed
the
feb2_with_trait
branch
2 times, most recently
from
90c7bf5 to
41d629d
Compare
jeffwashington
force-pushed
the
feb2_with_trait
branch
from
41d629d to
18e72c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #23311 +/- ##
========================================
Coverage 81.3% 81.4%
========================================
Files 573 573
Lines 156513 156610 +97
========================================
+ Hits 127383 127579 +196
+ Misses 29130 29031 -99 |
jeffwashington
force-pushed
the
feb2_with_trait
branch
2 times, most recently
from
3e12b5a to
8c08a09
Compare
|
Added some more tests. Verified snapshot startup time does not appear to be significantly impacted. Seems to be within the noise. |
brooksprumo
previously approved these changes
Mar 2, 2022
jeffwashington
force-pushed
the
feb2_with_trait
branch
from
8c08a09 to
cbd56ae
Compare
mergify
bot
dismissed
brooksprumo’s stale review
Pull request has been modified.
jeffwashington
force-pushed
the
feb2_with_trait
branch
from
cbd56ae to
99412d6
Compare
brooksprumo
reviewed
Mar 2, 2022
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Mar 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
this is used by ancient append vecs. Broken out here because of all the files and tests it touches.
Summary of Changes
Fixes #