(LedgerStore/FIFO) Refactor FIFO options and sanity check #23131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhchiang-sol
changed the title
steviez
reviewed
Feb 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #23131 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 570 570
Lines 155438 155445 +7
=========================================
- Hits 126452 126441 -11
- Misses 28986 29004 +18 |
steviez
reviewed
Feb 21, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR introduces BlockstoreRocksFifoOptions and performs a sanity check on FIFO options.
When the sanity check fails, blockstore will panic instead of falling back to level compaction.
This will allow users to easily identify and fix any misconfiguration.
Dependency: #23103