Minor refactor on Shreds column family descriptor construction. #23103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2022
steviez
previously approved these changes
Feb 15, 2022
ledger/src/blockstore_db.rs
Outdated
Comment on lines
1432
to
1436
| warn!( | ||
| " is must be greater than {} for RocksFifo.", | ||
| FIFO_WRITE_BUFFER_SIZE | ||
| ); |
There was a problem hiding this comment.
nit: Looks like you missed adding the column name back in when you consolidated:
warn!("{} cf_size must be greater than {} when using ShredStorageType::RocksFifo",
C::NAME, FIFO_WRITE_BUFFER_SIZE);
There was a problem hiding this comment.
Oh yep! Thanks for spotting that. Let me fix it!
mergify
bot
dismissed
steviez’s stale review
Pull request has been modified.
Codecov Report
@@ Coverage Diff @@
## master #23103 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 564 567 +3
Lines 153290 154368 +1078
=========================================
+ Hits 124726 125554 +828
- Misses 28564 28814 +250 |
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Feb 16, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Avoid duplicate code by having a template function to create shreds column family descriptor.