Adds test coverage for #20669 #20690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20690 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 495 495
Lines 137776 137785 +9
=========================================
- Hits 112917 112911 -6
- Misses 24859 24874 +15 |
jackcmay
reviewed
Oct 14, 2021
| @@ -1772,6 +1772,21 @@ mod tests { | |||
| assert_eq!(elf[i], *byte); | |||
| } | |||
|
|
|||
| // Invoke deployed program | |||
There was a problem hiding this comment.
Good to add more coverage here but what is this catching that something like the following isn't?
solana/programs/bpf/tests/programs.rs
Line 1751 in ad0a88f
There was a problem hiding this comment.
Sorry, my assessment of the problem was wrong. I updated the description of the PR.
To answer your question:
This new part covers the case in which the executor is not cached and needs to be created on invocation.
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit b6499d0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#20669 unveiled a gap in the tests:
Upgradeable loader BPF programs were invoked but the executor was already cached.
So the situation in which the executor needs to be created here never occurred.
Summary of Changes
Invoke the deployed program in
test_bpf_loader_upgradeable_deploy_with_max_len.Fixes #