Fix: #20598 #20669
Merged
Fix: #20598 #20669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add some test coverage to catch this next time? |
|
Sure, is already planned for tomorrow. |
Codecov Report
@@ Coverage Diff @@
## master #20669 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 495 495
Lines 137757 137763 +6
=========================================
- Hits 112911 112910 -1
- Misses 24846 24853 +7 |
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Oct 14, 2021
Lichtso
added a commit
that referenced
this pull request
Oct 18, 2021
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
* Makes argument / parameter interfaces more clear. * Fixes the bug in solana-labs#20598
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit b6499d0.
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit d9431a1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#20598 could not join MNB because of a wrong account index in the runtime.
Summary of Changes
Fixes the account index and renames the variables to avoid this kind of confusion in the future.
Fixes #