Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Overlapping program Ids #1623

Closed
wants to merge 3 commits into from
Closed

Fix Overlapping program Ids #1623

wants to merge 3 commits into from

Conversation

jackcmay
Copy link
Contributor

Problem

Overlapping program Ids

Summary of Changes

  • Fixed overlapping ids
  • Base programs (system, native loader) down low (0, 1). Other programs we plan to move out to dynamic modules start at 128

Fixes #1572

@jackcmay jackcmay added this to the v0.10 Pillbox milestone Oct 26, 2018
@jackcmay jackcmay self-assigned this Oct 26, 2018
@jackcmay jackcmay requested a review from mvines October 26, 2018 19:29
@mvines
Copy link
Member

mvines commented Oct 26, 2018

This PR has other commits in it, looks like from #1620. Is that intentional?

@jackcmay
Copy link
Contributor Author

Oops, overlapped branches trying to fix overlapping program ids

@jackcmay jackcmay closed this Oct 26, 2018
@jackcmay jackcmay deleted the update_program_ids branch October 30, 2018 03:33
Lichtso pushed a commit to Lichtso/solana that referenced this pull request Jun 6, 2024
@buffalojoec
Vote: hoist vote sender types up to runtime (solana-labs#1623)
31334c4 
vote: hoist vote sender types up to runtime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvines mvines Awaiting requested review from mvines

Assignees

@jackcmay jackcmay

Labels
None yet
Projects
None yet
Milestone
v0.10 Pillbox
Development

Successfully merging this pull request may close these issues.
2 participants
@jackcmay @mvines