Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built-in programs have overlapping ids and temporary programs are in same id namespace #1572

Closed
jackcmay opened this issue Oct 23, 2018 · 1 comment
Closed

Built-in programs have overlapping ids and temporary programs are in same id namespace #1572

jackcmay opened this issue Oct 23, 2018 · 1 comment
Milestone
v0.11 Tabletops

Comments

@jackcmay
Copy link
Contributor

BudgetProgram and StorageProgram have overlapping program_id's and the rest are sequential from 0.

Instead, any built-in program that is not intended to stay in the bank could be moved to a larger number to give room for the addition of newer built-ins that are intended to stay.

I would propose:
SystemProgram: 0
NativeLoader: 1
BpfLoader: 2

BudgetState: 256
StorageProgram: 257
TokenProgram: 258
TicTacToeProgram: 259
TicTacToeDashboardProgram: 260

(BudgetState, StorageProgram, and TokenProgram could live in the lower id space as 3, 4, 5 respectively).
@mvines mvines added this to the The Future! milestone Oct 23, 2018
@mvines
Copy link
Member

mvines commented Oct 23, 2018

Seems like a nice cleanup to do at a low pri. There's a minor SDK impact so in some ways just doing it like now would be nice

@jackcmay jackcmay changed the title Build-in programs have overlapping ids and temporary programs are in same id namespace Built-in programs have overlapping ids and temporary programs are in same id namespace Oct 24, 2018
This was referenced Oct 26, 2018
Closed
Merged
@garious garious modified the milestones: The Future!, v0.11 Tabletops Dec 9, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
@joncinque
stake-pool: Ensure zero pool token supply on init (solana-labs#1572)
7f89183
@adamlaska adamlaska mentioned this issue Jul 31, 2022
Closed
@Kashuhackerone Kashuhackerone mentioned this issue Jul 31, 2022
Open
@Muqingluan Muqingluan mentioned this issue Aug 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11 Tabletops
Development

No branches or pull requests
3 participants
@garious @mvines @jackcmay