Skip deserialization of readonly accounts #15813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackcmay
force-pushed
the
dont-deserialize-ro-accounts
branch
from
947a032 to
2594acf
Compare
Codecov Report
@@ Coverage Diff @@
## master #15813 +/- ##
=======================================
Coverage 80.1% 80.1%
=======================================
Files 407 407
Lines 106163 106259 +96
=======================================
+ Hits 85085 85168 +83
- Misses 21078 21091 +13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BPF loader deserializes accounts that were passed to the program as readonly. Now that write-deescalation is enforced deserializing an account that the caller shouldn't write to is a waste.
Summary of Changes
Skip the deserialization of any accounts passed to the program as read-only and thus ignore any local changes they may have made to the local copy
Fixes #