You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When passing accounts to invoke the runtime copies the data out of the program space, calls the inner instruction processor, and then copies the data back. Now that programs exit on any error these copy operations are probably not necessary:
Remove this copy and just use the buffer directly.
Doing so s complicated by the fact that the buffer might be realloc via SystemProgram::CreateAccount or more generally later and there could be a conflict between the runtime and in-program allocator.
The text was updated successfully, but these errors were encountered:
Problem
When passing accounts to
invoke
the runtime copies the data out of the program space, calls the inner instruction processor, and then copies the data back. Now that programs exit on any error these copy operations are probably not necessary:Specifically:
solana/programs/bpf_loader/src/syscalls.rs
Line 1010 in df8cafe
solana/programs/bpf_loader/src/syscalls.rs
Line 1620 in df8cafe
Context: #14523
Proposed Solution
Remove this copy and just use the buffer directly.
Doing so s complicated by the fact that the buffer might be realloc via
SystemProgram::CreateAccount
or more generally later and there could be a conflict between the runtime and in-program allocator.The text was updated successfully, but these errors were encountered: