Share RO and Executable accounts within invocations #15799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15799 +/- ##
=========================================
- Coverage 80.1% 80.1% -0.1%
=========================================
Files 407 407
Lines 106084 106108 +24
=========================================
- Hits 85046 85032 -14
- Misses 21038 21076 +38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During cross-program invocations, unnecessary copies of accounts are taking place in instances where the account is read-only or executable by the caller.
Summary of Changes
Share instead of copy these accounts. Measured around 4-5% reduction in the compute time while verifying the ledger with ledger-tool
Fixes #