Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FutureResult to return a Future that immediately resolves #150

Merged
merged 1 commit into from
Apr 26, 2018

Conversation

garious
Copy link
Contributor

@garious garious commented Apr 26, 2018

Fixes #141

@garious
Copy link
Contributor Author

garious commented Apr 26, 2018

Thanks @rlkelly, but I wanted your contribution now. :)

Don't worry about those return values. I see that it's a pain to handle those alongside futures, and I'm planning to rewrite a lot of these functions anyway. I'll take care of it over that.

@garious garious mentioned this pull request Apr 26, 2018
@codecov-io
Copy link

codecov-io commented Apr 26, 2018

Codecov Report

Merging #150 into master will decrease coverage by 0.04%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   96.47%   96.43%   -0.05%     
==========================================
  Files          19       19              
  Lines        2072     2076       +4     
==========================================
+ Hits         1999     2002       +3     
- Misses         73       74       +1
Impacted Files Coverage Δ
src/lib.rs 100% <ø> (ø) ⬆️
src/accountant_skel.rs 95.57% <100%> (ø) ⬆️
src/accountant_stub.rs 92.95% <81.25%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753eaa8...34d1805. Read the comment docs.

@garious garious merged commit 02c7eea into solana-labs:master Apr 26, 2018
@rlkelly
Copy link
Contributor

rlkelly commented Apr 26, 2018

should we make a ticket for the error handling you mentioned in your comments?

@garious
Copy link
Contributor Author

garious commented Apr 26, 2018

yep, will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants