141 add futures #148
Closed
141 add futures #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
Apr 25, 2018
| @@ -81,6 +81,12 @@ impl Accountant { | |||
| true | |||
| } | |||
|
|
|||
| // fn forget_signature_with_last_id(&self, last_id: &Hash) -> bool { | |||
There was a problem hiding this comment.
Don't need this. Even if not commented out, it's not right. It should remove last_id, not the last item.
| @@ -51,35 +52,38 @@ impl AccountantStub { | |||
| /// Request the balance of the user holding `pubkey`. This method blocks | |||
| /// until the server sends a response. If the response packet is dropped | |||
| /// by the network, this method will hang indefinitely. | |||
| pub fn get_balance(&self, pubkey: &PublicKey) -> io::Result<Option<i64>> { | |||
| pub fn get_balance(&self, pubkey: &PublicKey) -> FutureResult<i64, i64> { | |||
There was a problem hiding this comment.
How about something likeFutureResult<Option<i64>, io::Error> ? Or perhaps the library offers a futures::io::FutureResult<Option<i64>>?
| let req = Request::GetBalance { key: *pubkey }; | ||
| let data = serialize(&req).expect("serialize GetBalance"); | ||
| self.socket.send_to(&data, &self.addr)?; | ||
| self.socket.send_to(&data, &self.addr).expect("buffer error"); |
There was a problem hiding this comment.
Can't panic on this one. It's too likely to happen.
| } | ||
|
|
||
| /// Request the last Entry ID from the server. This method blocks | ||
| /// until the server sends a response. At the time of this writing, | ||
| /// it also has the side-effect of causing the server to log any | ||
| /// entries that have been published by the Historian. | ||
| pub fn get_last_id(&self) -> io::Result<Hash> { | ||
| pub fn get_last_id(&self) -> FutureResult<Hash, ()> { |
There was a problem hiding this comment.
Again, io::Errror instead of ()?
|
sure thing, i'll knock this out in a few hours |
|
See #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.