This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Add GetConfirmedBlocksWithLimit RPC method #12599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetConfirmedBlocks
requires that I provide anend_slot
or else I get fed up to 500,000 blocks. This is wasteful when I just want to poke around the ledger and return a block or two after a given slot (eg, the first block in an epoch).To get around this add
GetConfirmedBlocksWithLimit
, which requires a starting slot and a limit.Adding a new method seemed conceptually much simpler than trying to shoehorn an optional limit argument at the end of
GetConfirmedBlocks
. AlsoGetConfirmedBlocks
still has it's uses (ie, when I want to fetch all confirmed blocks in a given epoch) so it deserves to continue to exist as a non-deprecated method alongsideGetConfirmedBlocksWithLimit