Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

RPC: getConfirmedBlocks doesn't limit return results #10091

Closed
jstarry opened this issue May 17, 2020 · 1 comment
Closed

RPC: getConfirmedBlocks doesn't limit return results #10091

jstarry opened this issue May 17, 2020 · 1 comment
Milestone
v1.4.0

Comments

@jstarry
Copy link
Contributor

jstarry commented May 17, 2020 •
edited
Loading

Problem

If getConfirmedBlocks is called with no end slot and the start slot equal to the earliest stored root, the entire list of roots will be returned.

Proposed Solution

Limit the length of the returned roots list
@mvines mvines added this to the v1.3.0 milestone May 21, 2020
@mvines mvines modified the milestones: v1.3.0, v1.4.0 Aug 5, 2020
@mvines mvines modified the milestones: v1.4.0, v1.5.0 Oct 8, 2020
@mvines
Copy link
Contributor

mvines commented Oct 8, 2020

Fixed by #12599

@mvines mvines closed this as completed Oct 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
2 participants
@jstarry @mvines