Fix check_switch_threshold and add switch threshold local cluster tests
#11138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11138 +/- ##
=========================================
- Coverage 82.2% 82.1% -0.1%
=========================================
Files 319 319
Lines 73795 73859 +64
=========================================
+ Hits 60690 60696 +6
- Misses 13105 13163 +58 |
Fix switch threshold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Rebased and fixed up: #10343
Summary of Changes
@ryoqun fyi, added some tests for the switching threshold and fixed some switching threshold issues (described in #10343). May have some implications for tests in #10718.
Fixes #