Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook up webwallet to wallet API #951

Closed
mvines opened this issue Aug 12, 2018 · 4 comments
Closed

Hook up webwallet to wallet API #951

mvines opened this issue Aug 12, 2018 · 4 comments
Assignees
@mvines
Milestone
v0.8 Windansea

Comments

@mvines
Copy link
Member

mvines commented Aug 12, 2018

The webwallet is now ready to be connected up with #702.

Notes:

  • Likely use the https://www.npmjs.com/package/json-rpc2 to make the RPC calls into the API
  • The binary format of a transaction will need to be replicated into the webwallet and perhaps more formally documented at the byte level, since webwallet will sign its own transactions.
@mvines mvines added this to the v0.9.0 milestone Aug 12, 2018
@mvines mvines self-assigned this Aug 12, 2018
@mvines
Copy link
Member Author

mvines commented Aug 12, 2018

@CriesofCarrots if you have a list of methods that you’re looking adding in #702, I can get those implemented in the webwallet real quick. Then you could potentially use the webwallet as a client to actually develop the RPC API implementation

@mvines
Copy link
Member Author

mvines commented Aug 20, 2018 •
edited
Loading

getBalance() - solana-labs/obsolete-dontuse-example-webwallet@47b2cd7

@mvines
Copy link
Member Author

mvines commented Aug 20, 2018

confirmTransaction() - solana-labs/obsolete-dontuse-example-webwallet@f2f7755

@mvines
Copy link
Member Author

mvines commented Aug 24, 2018

What remains here is now a duplicate of what remains for #1022

@mvines mvines closed this as completed Aug 24, 2018
joncinque pushed a commit to joncinque/solana that referenced this issue Jun 18, 2024
@kevinheavey
Extract curve25519 crate from zk-token-sdk (solana-labs#951)
b855bd0 
* extract curve25519 crate

* remove obsolete comment

* fix Cargo.toml files

* fix imports

* update lock file

* remove unused deps from zk-token-sdk

* fmt

* add solana-curve25519 patch

* add missing override to programs/sbf/Cargo.toml

* copy over an allow()

* move new crate to curves dir

* use workspace version

* add back missing dev dep

* add missing dependencies to programs/sbf

* fmt

* move dep to the correct dependency table

* remove #[cfg(not(target_os = "solana"))] above errors mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvines mvines

Labels
None yet
Projects
None yet
Milestone
v0.8 Windansea
Development

No branches or pull requests
1 participant
@mvines