Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up / ship webwallet #1022

Closed
mvines opened this issue Aug 20, 2018 · 3 comments
Closed

Clean up / ship webwallet #1022

mvines opened this issue Aug 20, 2018 · 3 comments
Assignees
@mvines
Milestone
v0.8 Windansea

Comments

@mvines
Copy link
Member

mvines commented Aug 20, 2018

This is just a web version of the wallet cli, no additional scope in v0.8.
@mvines mvines added this to the v0.8.0 Windansea milestone Aug 20, 2018
@mvines mvines self-assigned this Aug 20, 2018
@mvines
Copy link
Member Author

mvines commented Aug 22, 2018 •
edited
Loading

Lots of progress/cleanup at https://github.com/solana-labs/webwallet today. Main pieces remaining:

@mvines
Copy link
Member Author

mvines commented Aug 24, 2018 •
edited
Loading

Mostly done.

All that remains is to decide what we're going to do about sending tokens for v0.8 via the RPC API. If we'll support this then:

  • the solana-web3.js API needs to be fixed to create a properly formatted transaction
  • Ensure the example-wallet actually send tokens correctly. It should but maybe there's some bugs...

@mvines mvines mentioned this issue Aug 24, 2018
Closed
@mvines
Copy link
Member Author

mvines commented Aug 25, 2018

As of @solana/web3.js v0.0.5, sending tokens from the web wallet works:

The transaction format is horribly hardcoded in @solana/web3.js and it'll break in the future, but happy to run on that treadmill for a while in exchange for proving that the end-to-end integration works.

@mvines mvines closed this as completed Aug 25, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
@dependabot
build(deps): bump @solana/web3.js from 0.87.1 to 0.88.0 in /token/js (s…
7ed82d7 
…olana-labs#1022)

Bumps [@solana/web3.js](https://github.com/solana-labs/solana-web3.js) from 0.87.1 to 0.88.0.
- [Release notes](https://github.com/solana-labs/solana-web3.js/releases)
- [Commits](solana-labs/solana-web3.js@v0.87.1...v0.88.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvines mvines

Labels
None yet
Projects
None yet
Milestone
v0.8 Windansea
Development

No branches or pull requests
1 participant
@mvines