Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore rolling testnet updates #695

Closed
mvines opened this issue Jul 19, 2018 · 1 comment
Closed

Restore rolling testnet updates #695

mvines opened this issue Jul 19, 2018 · 1 comment
Milestone
v0.11 Tabletops

Comments

@mvines
Copy link
Member

mvines commented Jul 19, 2018

It looks like there's still some badness in crdt that doesn't get flushed out when a network is updated incrementally. Let's figure out why, fix it and then revert #694.

A good first step here could be #693.
@mvines mvines added this to the The Future! milestone Jul 19, 2018
@mvines mvines mentioned this issue Jul 19, 2018
Closed
@mvines
Copy link
Member Author

mvines commented Sep 9, 2018

Obsolete

@mvines mvines closed this as completed Sep 9, 2018
@garious garious modified the milestones: The Future!, v0.11 Tabletops Dec 9, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
@joncinque
token-swap: Add fee account to receive withdraw / trading fees, tradi…
b0867c7 
…ng token mints (solana-labs#695)

* Add mints to swap info

* Add mints to JS

* Add fee account in SwapInfo / init

* Add test for 0 fee, init test fully

* Add withdraw command interface

* Add fee accounts to swap instruction

* Add calculations for swap and withdraw fees

* Run cargo fmt

* Add new fees to JS and test

* Review feedback: fixup instruction doc and clone

* Update order of accounts in instructions

* Run cargo fmt

* Fix owner fee pool token calculation to include trading fee

* Add owner fees to flat curve, per request

* Fix instruction comment numbering

* Add more errors types for clearer calculation errors

Add a check for withdrawing from fee account

* Cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11 Tabletops
Development

No branches or pull requests
2 participants
@garious @mvines