Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master.testnet.solana.com node count is too damn high! #712

Closed
mvines opened this issue Jul 19, 2018 · 2 comments · Fixed by #1194
Closed

master.testnet.solana.com node count is too damn high! #712

mvines opened this issue Jul 19, 2018 · 2 comments · Fixed by #1194
Assignees
Milestone

Comments

@mvines
Copy link
Member

mvines commented Jul 19, 2018

After resetting m.t.s.c, the node count should be exactly 50 (unless somebody is running extra validator nodes attached to m.t.s.c -- possible but unlikely at this point).

After adding 17d927a, it shows a node count of 80 or other numbers not 50.

It's possible we have some kind of crdt table issue.

STR: Look at the output from the latest build at https://buildkite.com/solana-labs/testnet-deploy

cc: #693
cc: #695

@rob-solana
Copy link
Contributor

@mvines, still an issue?

@mvines
Copy link
Member Author

mvines commented Aug 16, 2018

I suspect it is but we don't have a nice way to detect if/when this happens. I think we could add a --strict flag to bench-tps that turns this expression [1] from a < to !=, then enable --strict on the internal testnets. If it doesn't blow up then this issue can be closed

[1]

if validators.len() < num_nodes {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants