Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Gate: Remove support for RequestUnitsDeprecated instruction #27500

Closed
tao-stones opened this issue Aug 31, 2022 · 0 comments · Fixed by #27503
Closed

Feature Gate: Remove support for RequestUnitsDeprecated instruction #27500

tao-stones opened this issue Aug 31, 2022 · 0 comments · Fixed by #27503
Assignees
@tao-stones
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@tao-stones
Copy link
Contributor

tao-stones commented Aug 31, 2022 •
edited
Loading

Description

ComputeBudgetInstruction::RequestUnitsDeprecated can be removed since its set_compute_unit_price has been enabled.

Feature ID

EfhYd3SafzGT472tYQDUc4dPd2xdEfKs5fwkowUgVt4W

Activation Method

Single Core Contributor

Minimum Beta Version

1.15.0

Minimum Stable Version

No response

Testnet Activation Epoch

501

Devnet Activation Epoch

561

Mainnet-Beta Activation Epoch

540
@tao-stones tao-stones added the feature-gate Pull Request adds or modifies a runtime feature gate label Aug 31, 2022
@tao-stones tao-stones self-assigned this Aug 31, 2022
@tao-stones tao-stones changed the title Feature Gate: Remove deprecated ComputeBudget instruction Feature Gate: Remove support for RequestUnitsDeprecated instruction Aug 31, 2022
tao-stones added a commit to tao-stones/solana that referenced this issue Aug 31, 2022
@tao-stones
feature gate: remove support for RequestUnitsDeprecated instruction s…
d4f549b 
…olana-labs#27500
@tao-stones tao-stones mentioned this issue Aug 31, 2022
Merged
tao-stones added a commit to tao-stones/solana that referenced this issue Aug 31, 2022
@tao-stones
feature gate: remove support for RequestUnitsDeprecated instruction s…
072df04 
…olana-labs#27500
tao-stones added a commit to tao-stones/solana that referenced this issue Aug 31, 2022
@tao-stones
feature gate: remove support for RequestUnitsDeprecated instruction s…
accd1a2 
…olana-labs#27500
tao-stones added a commit to tao-stones/solana that referenced this issue Sep 9, 2022
@tao-stones
feature gate: remove support for RequestUnitsDeprecated instruction s…
7103501 
…olana-labs#27500
@mergify mergify bot closed this as completed in #27503 Sep 9, 2022
mergify bot pushed a commit that referenced this issue Sep 9, 2022
@tao-stones @jstarry
Add feature gate to remove support for RequestUnitsDeprecated instruc…
ced8f6a 
…tion (#27503)

* feature gate: remove support for RequestUnitsDeprecated instruction #27500

* review update: stop support deprecated ix for prioritization

* Apply suggestions from code review

Co-authored-by: Justin Starry <[email protected]>

Co-authored-by: Justin Starry <[email protected]>
@tao-stones tao-stones reopened this Sep 12, 2022
@tao-stones tao-stones mentioned this issue May 25, 2023
Closed
@tao-stones tao-stones mentioned this issue Nov 30, 2023
Merged
@Lichtso Lichtso closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tao-stones tao-stones

Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add feature gate to remove support for RequestUnitsDeprecated instruction tao-stones/solana
2 participants
@Lichtso @tao-stones