Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support of RequestUnitsDeprecated::additional_fee when prioritization_fee_type_change feature is activated #25201

Closed
tao-stones opened this issue May 13, 2022 · 3 comments

Comments

@tao-stones
Copy link
Contributor

Problem

Concern raised here.

Proposed Solution

remove support of RequestUnitsDeprecated::additional_fee when feature prioritization_fee_type_change is activated

@jstarry
Copy link
Member

jstarry commented May 15, 2022

The concern I raised in #25178 has been resolved for now, but I think we should still eventually deprecate this instruction

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label May 16, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2023
@tao-stones tao-stones reopened this May 24, 2023
@tao-stones
Copy link
Contributor Author

feature add_set_compute_unit_price (early was called prioritization_fee_type_change) had been activated in all cluster:

solana feature status 98std1NSHqXi9WYvFShfVepRdCoq1qvsp8fsR2XZtG8g -ut
Feature                                      | Status                  | Activation Slot | Description
98std1NSHqXi9WYvFShfVepRdCoq1qvsp8fsR2XZtG8g | active since epoch 332  | 137900256       | add compute budget ix for setting a compute unit price

solana feature status 98std1NSHqXi9WYvFShfVepRdCoq1qvsp8fsR2XZtG8g -ud
Feature                                      | Status                  | Activation Slot | Description
98std1NSHqXi9WYvFShfVepRdCoq1qvsp8fsR2XZtG8g | active since epoch 332  | 143424000       | add compute budget ix for setting a compute unit price

solana feature status 98std1NSHqXi9WYvFShfVepRdCoq1qvsp8fsR2XZtG8g -um
Feature                                      | Status                  | Activation Slot | Description
98std1NSHqXi9WYvFShfVepRdCoq1qvsp8fsR2XZtG8g | active since epoch 329  | 142128000       | add compute budget ix for setting a compute unit price

The deprecated instruction is still being used in MNB, example.

@github-actions github-actions bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label May 25, 2023
@tao-stones
Copy link
Contributor Author

feature gate to remove deprecated ix has been scheduled and is pending. Close this Issue, tracing removal at #27500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants