stake-pool: Update program to work with minimum delegation #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
commented
Apr 29, 2022
| @@ -747,7 +745,7 @@ impl Processor { | |||
| stake_pool.manager_fee_account = *manager_fee_info.key; | |||
| stake_pool.token_program_id = *token_program_info.key; | |||
| stake_pool.total_lamports = total_lamports; | |||
| stake_pool.pool_token_supply = 0; | |||
| stake_pool.pool_token_supply = total_lamports; | |||
There was a problem hiding this comment.
The tests uncovered this little oopsie!
brooksprumo
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The minimum delegation will be raised with solana-labs/solana#24603, and the minimum reserve amount will be lowered with solana-labs/solana#24670 -- the stake pool program needs to be ready for that!
Solution
Update the minimum active stake amount and the minimum reserve amount as required. This was tested against the changes to raise the minimum delegation to 1 SOL, but not the second PR. The hope is that the only change will be to update
MINIMUM_RESERVE_LAMPORTSto0.The best option will be to call
get_minimum_delegationon the stake program, but that hasn't landed in any of the Solana crates yet.We can land this PR to unblock solana-labs/solana#24603 if needed, or keep it as a draft. We won't redeploy the program until the new instruction makes it anyway.