This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
stake-pool: Use stake program minimum delegation #3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
reviewed
Aug 29, 2022
|
It's all ready for you tomorrow, thanks for the review! |
brooksprumo
reviewed
Aug 30, 2022
There was a problem hiding this comment.
Looks good! Some questions due to my ignorance, then I imagine it'll be good to go.
Are there any concerns about needing new/more tests? Nothing jumped out at me w.r.t. the minimum delegation, since the pool's minimum is still effectively 1 SOL. Same for MINIMUM_RESERVE_LAMPORTS, since that was 1 lamport before as well.
For this one, not yet, since it'll work as expected. The next PR is adding a check during |
|
Ok, this should be good for another pass |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the stake pool program hardcodes a minimum delegation amount of 0.001 SOL in the program, but the stake program will soon enforce a higher minimum delegation amount.
Solution
Use the maximum of the previous value (0.001 SOL) and the value reported by the stake program's
get_minimum_delegationinstruction.