This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Remove disabled infinite loop check #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dmakarov
added a commit
that referenced
this pull request
Nov 15, 2021
- Fix R_BPF_64_64 relocation handling (#225) - Fixes the build of the CLI tool. (#224) - Clearify error message MultipleTextSections => NotOneTextSection. (#223) - Remove disabled infinite loop check (#219) - Fix tests to pass on non-X86_64 architectures (#218) - Fix Beta CI Tests (#216) - Make disassembler output more readable (#215) - Makes #212 configurable for feature gate. (#213) - Fix verifier shift instruction overflows imm value (#212)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The infinite loop check in the BPF verifier just checked for a tight infinite loop (jump to same current PC) which doesn't actually protect execution from malicious behavior be any infinite loop will have the same effect. And, keeping the check in would reject any new or existing program from containing a jump to present PC even if it is in dead code.
Remove the remnants of this check because the compute meter protects against infinite programs and adding this check could break existing programs.