Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Make disassembler output more readable #215

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Conversation

dmakarov
Copy link

Fixes #214

@dmakarov dmakarov requested a review from Lichtso September 16, 2021 09:58
Copy link

@Lichtso Lichtso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself looks good, but I will have to fix the CI tests in general.
It appears the upcoming Rust version changed the memory layout of returning an Option or something like that.

@dmakarov
Copy link
Author

I was also looking at the failed tests. Will merge this one for now, as the failures are unrelated to these changes. With the beta Rust the tests fail also without the changes in this PR.

@dmakarov dmakarov merged commit c3dd337 into solana-labs:main Sep 17, 2021
@dmakarov dmakarov mentioned this pull request Nov 15, 2021
dmakarov added a commit that referenced this pull request Nov 15, 2021
- Fix R_BPF_64_64 relocation handling (#225)
- Fixes the build of the CLI tool. (#224)
- Clearify error message MultipleTextSections => NotOneTextSection. (#223)
- Remove disabled infinite loop check (#219)
- Fix tests to pass on non-X86_64 architectures (#218)
- Fix Beta CI Tests (#216)
- Make disassembler output more readable (#215)
- Makes #212 configurable for feature gate. (#213)
- Fix verifier shift instruction overflows imm value (#212)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disassembler not correctly representing negative offsets
2 participants