Remove Clone from TokenStream #1701
Closed
+14
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2024
maciektr
force-pushed
the
spr/dev/55ec12c0
branch
from
068db62
to
308f593
Compare
maciektr
force-pushed
the
spr/dev/c34c8d99
branch
from
775b697
to
ecf7f5f
Compare
maciektr
force-pushed
the
spr/dev/c34c8d99
branch
from
ecf7f5f
to
76365eb
Compare
This was referenced Oct 28, 2024
Closed
commit-id:c34c8d99
maciektr
force-pushed
the
spr/dev/c34c8d99
branch
from
76365eb
to
6711319
Compare
wawel37
approved these changes
Nov 5, 2024
| @@ -308,14 +308,15 @@ impl ProcMacroHostPlugin { | |||
| return all_none; | |||
| } | |||
| }; | |||
| let original = token_stream.to_string(); | |||
There was a problem hiding this comment.
nit:
Suggested change
| let original = token_stream.to_string(); | |
| let token_stream_string = token_stream.to_string(); |
| @@ -597,10 +598,11 @@ impl ProcMacroHostPlugin { | |||
| token_stream: TokenStream, | |||
| stable_ptr: SyntaxStablePtrId, | |||
| ) -> PluginResult { | |||
| let original = token_stream.to_string(); | |||
|
Closing pull request: commit has gone away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack: