-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework internal TokenStream representation #1699
Open
maciektr
wants to merge
1
commit into
dev
Choose a base branch
from
spr/dev/ab3e2fd1
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+533
−261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2024
maciektr
force-pushed
the
spr/dev/ab3e2fd1
branch
from
October 28, 2024 12:38
a42c869
to
1d30340
Compare
This was referenced Oct 28, 2024
Closed
maciektr
force-pushed
the
spr/dev/ab3e2fd1
branch
from
October 30, 2024 09:39
1d30340
to
399ff25
Compare
This is just #1639 but moved to a stack |
wawel37
approved these changes
Nov 5, 2024
@@ -14,7 +14,7 @@ repository.workspace = true | |||
|
|||
[dependencies] | |||
cairo-lang-macro-attributes = "0.1" | |||
cairo-lang-macro-stable = "1" | |||
cairo-lang-macro-stable = { path = "../cairo-lang-macro-stable" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note to change it during the release
@@ -23,7 +23,7 @@ cairo-lang-filesystem.workspace = true | |||
cairo-lang-formatter.workspace = true | |||
cairo-lang-lowering.workspace = true | |||
cairo-lang-macro = { path = "../plugins/cairo-lang-macro" } | |||
cairo-lang-macro-stable = "1" | |||
cairo-lang-macro-stable = { path = "../plugins/cairo-lang-macro-stable" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
commit-id:ab3e2fd1
maciektr
force-pushed
the
spr/dev/ab3e2fd1
branch
from
November 8, 2024 11:21
399ff25
to
7e073fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack: