Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highlight.js / hidden line rust. #1566

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

wawel37
Copy link
Contributor

@wawel37 wawel37 commented Aug 30, 2024

fix #1565

Why?

mdBook during the parsing, put's all the hidden lines (beggining with #) inside the span tag with className="boring".
mdBook generated css files sets all the files with boring className to be display: none. Unfortunately, new version of highlight.js wipes all those mdBook spans during the highlighting process.

This version of highlight.js is based directly upon the mdBook highlight.js, so hidden lines work as intended inside rust codes examples.

@maciektr maciektr self-requested a review August 31, 2024 09:36
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wawel37 wawel37 added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 473afac Sep 3, 2024
22 checks passed
@wawel37 wawel37 deleted the doc/highlightjs-update branch September 3, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research highlight.js not supporting rust hidden lines
2 participants