Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research highlight.js not supporting rust hidden lines #1565

Closed
wawel37 opened this issue Aug 29, 2024 · 1 comment · Fixed by #1566
Closed

Research highlight.js not supporting rust hidden lines #1565

wawel37 opened this issue Aug 29, 2024 · 1 comment · Fixed by #1566
Assignees
@wawel37
Labels
scarb-doc

Comments

@wawel37
Copy link
Contributor

wawel37 commented Aug 29, 2024

No description provided.

@wawel37 wawel37 self-assigned this Aug 29, 2024
@enitrat
Copy link
Contributor

enitrat commented Aug 29, 2024

Context: https://rust-lang.github.io/mdBook/format/mdbook.html#hiding-code-lines

@enitrat enitrat mentioned this issue Aug 29, 2024
Closed
@maciektr maciektr mentioned this issue Sep 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 3, 2024
@wawel37
Update highlight.js / hidden line rust. (#1566)
473afac 
fix #1565 

## Why?
mdBook during the parsing, put's all the hidden lines (beggining with
`#`) inside the `span` tag with `className="boring"`.
mdBook generated css files sets all the files with `boring` className to
be `display: none`. Unfortunately, new version of `highlight.js` wipes
all those mdBook spans during the highlighting process.

This version of `highlight.js` is based directly upon the mdBook
`highlight.js`, so hidden lines work as intended inside rust codes
examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wawel37 wawel37

Labels
scarb-doc
Projects
Scarb
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update highlight.js / hidden line rust. software-mansion/scarb
2 participants
@wawel37 @enitrat