Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snforge-test-collector] Add TestDetails to TestCaseRaw #1121

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

drknzz
Copy link
Contributor

@drknzz drknzz commented Feb 7, 2024

Copy link
Contributor

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general but no idea how should I verify those tests xD Would prob wait with merging until we make a PR integrating it into forge and check it locally that it works

Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments attached

Cargo.toml Outdated Show resolved Hide resolved
@drknzz drknzz requested a review from maciektr February 13, 2024 15:03
@maciektr
Copy link
Contributor

maciektr commented Feb 13, 2024

Thank you! Let me know if we can merge.

@drknzz
Copy link
Contributor Author

drknzz commented Feb 14, 2024

Thank you! Let me know if we can merge.

Let's merge 👍

Update test.rs

Revert Cargo.toml formatting

Add TypSizeMap to FunctionFinder
@maciektr maciektr added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit a28b779 Feb 14, 2024
22 checks passed
@maciektr maciektr deleted the drknzz/collector-types branch February 14, 2024 12:14
@maciektr maciektr mentioned this pull request Feb 14, 2024
github-merge-queue bot pushed a commit to foundry-rs/starknet-foundry that referenced this pull request Feb 21, 2024
<!-- Reference any GitHub issues resolved by this PR -->

Closes #1394

## Introduced changes

<!-- A brief description of the changes -->
- Bump cairo to **2.5.4**
- Use changes introduced in
[software-mansion/scarb#1121](software-mansion/scarb#1121)

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
Draggu pushed a commit to foundry-rs/starknet-foundry that referenced this pull request Feb 22, 2024
<!-- Reference any GitHub issues resolved by this PR -->

Closes #1394

## Introduced changes

<!-- A brief description of the changes -->
- Bump cairo to **2.5.4**
- Use changes introduced in
[software-mansion/scarb#1121](software-mansion/scarb#1121)

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants