-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[snforge-test-collector
] Add TestDetails
to TestCaseRaw
#1121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general but no idea how should I verify those tests xD Would prob wait with merging until we make a PR integrating it into forge and check it locally that it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments attached
extensions/scarb-snforge-test-collector/src/compilation/test_collector.rs
Outdated
Show resolved
Hide resolved
Thank you! Let me know if we can merge. |
Let's merge 👍 |
Update test.rs Revert Cargo.toml formatting Add TypSizeMap to FunctionFinder
ee979c7
to
69fe8fc
Compare
<!-- Reference any GitHub issues resolved by this PR --> Closes #1394 ## Introduced changes <!-- A brief description of the changes --> - Bump cairo to **2.5.4** - Use changes introduced in [software-mansion/scarb#1121](software-mansion/scarb#1121) ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
<!-- Reference any GitHub issues resolved by this PR --> Closes #1394 ## Introduced changes <!-- A brief description of the changes --> - Bump cairo to **2.5.4** - Use changes introduced in [software-mansion/scarb#1121](software-mansion/scarb#1121) ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
foundry-rs/starknet-foundry#1394